DC Mission 4172 - Polished for QAS #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mples into mission_4172
jglander
suggested changes
Sep 22, 2024
There was a problem hiding this comment.
Required change:
- replace list type variable
hana_cloud_adminswith a string type variablehana_system_admin
Reason:
- The intended custom input field (quick account setup booster) for this variable does only support text type (not yet lists).
see proposed changes in main.tf, variables.tf and sample.tfvars
|
@jglander this is fixed now. Thanks for the suggestions!! |
jglander
approved these changes
Sep 23, 2024
lechnerc77
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Pull Request Type
What kind of change does this Pull Request introduce?
Other Information