Skip to content

DC Mission 3348 - Polished for QAS #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

mahesh0431
Copy link
Contributor

Purpose

  • DC Mission 3348 - Polished for QAS

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Documentation content changes
[X] Other... Please describe: Code clean up for QAS

Other Information

Copy link
Contributor

@jglander jglander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add service instance dashboard url

in output.tf add

output "sac_instance_dashboard_url" {
  value = btp_subaccount_service_instance.sac.dashboard_url
}

in provider.tf:

replace version value "~> 1.5.0" with "~> 1.6.0"

(service instance dashboard url: see what's new in 1.6 blog https://community.sap.com/t5/technology-blogs-by-sap/terraform-provider-for-sap-btp-version-1-6-0-what-s-new/ba-p/13810217)

@mahesh0431
Copy link
Contributor Author

mahesh0431 commented Sep 23, 2024

@jglander, thanks for the suggestions, just found out that service instance dashboard URL is added in the new versions of the btp provider, this helps!. This is fixed now

Copy link
Contributor

@jglander jglander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qas enabled version looks good to me, sapids and custom idp both work for me.

@lechnerc77 lechnerc77 merged commit 81874d2 into SAP-samples:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants