-
Notifications
You must be signed in to change notification settings - Fork 31
DC Mission 3348 - Polished for QAS #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mples into mission_3348
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add service instance dashboard url
in output.tf add
output "sac_instance_dashboard_url" {
value = btp_subaccount_service_instance.sac.dashboard_url
}
in provider.tf:
replace version value "~> 1.5.0" with "~> 1.6.0"
(service instance dashboard url: see what's new in 1.6 blog https://community.sap.com/t5/technology-blogs-by-sap/terraform-provider-for-sap-btp-version-1-6-0-what-s-new/ba-p/13810217)
@jglander, thanks for the suggestions, just found out that service instance dashboard URL is added in the new versions of the btp provider, this helps!. This is fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qas enabled version looks good to me, sapids and custom idp both work for me.
Purpose
Pull Request Type
What kind of change does this Pull Request introduce?
Other Information