Skip to content

3260: Fix & polished the QAS enabled Mission #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2024
Merged

3260: Fix & polished the QAS enabled Mission #315

merged 4 commits into from
Sep 18, 2024

Conversation

jglander
Copy link
Contributor

  • Fix: Added CF environment so that process automation app subscription works
  • Make custom idp working
  • Polished script code to be consistent with other QAS Missions

Pull Request Type

[x] Bugfix
[x] Feature
[ ] Documentation content changes
[x] Clean-up code to be consistent with other mission scripts (like 4024 or 3585)

@jglander
3260: Fix & Polished the QAS enabled Mission
5cb32b4 
* Fix: Added CF environment
* Polished script code to be consistent with other QAS Missions
@jglander
fix formatting issue
d117304
@jglander
fix formatting issues
d859cad
navyakhurana
navyakhurana approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@navyakhurana navyakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

lechnerc77
lechnerc77 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit 519a88c into SAP-samples:main Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

@navyakhurana navyakhurana navyakhurana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglander @lechnerc77 @navyakhurana