Skip to content

4441: Polished QAS enabled Mission #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2024
Merged

4441: Polished QAS enabled Mission #309

merged 3 commits into from
Sep 9, 2024

Conversation

jglander
Copy link
Contributor

@jglander jglander commented Sep 9, 2024

Purpose

  • polished code to be consistent with other QAS enabled missions (like 4024, 3585, ...)

Pull Request Type

[ ] Bugfix
[ ] Feature
[ ] Documentation content changes
[x] Clean-up code consistent with other mission scripts (like 4024 or 3585)

jglander and others added 2 commits September 9, 2024 08:06
@jglander
4441: Polished QAS enabled Mission
f4d13fe 
- polished code to be consistent with other QAS enabled missions (like 4024, 3585, ...)
@rui1610
Merge branch 'main' into 4441-patch-1
b1a1e93
rui1610
rui1610 suggested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change I'd propose is the removal of the email validation (see my comment in varriables.tf).
Rest looks good to me.

rui1610
rui1610 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rui1610 rui1610 merged commit 82cf97b into SAP-samples:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rui1610 rui1610 rui1610 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglander @rui1610