small fixes for QAS for mission 4441 #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanneseschrig I had to make a few minimal changes for mission 4441 to work with QAS |
|
@lechnerc77, @rui1610: Can one of you have a look? I'm not sure @johanneseschrig has permissions to approve. |
Removing not needed ${} for the users
rui1610
reviewed
Aug 21, 2024
released/discovery_center/mission_4441/minimal_setup_enterprise/step2/main.tf
Show resolved
Hide resolved
rui1610
suggested changes
Aug 21, 2024
Thanks. Somehow I can't see your suggestions in this PR though 🤔 |
Sorry, just didn't notice the change :) LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Pull Request Type
What kind of change does this Pull Request introduce?