Skip to content

Feature/build code mission #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johanneseschrig
Copy link
Contributor

@johanneseschrig johanneseschrig commented Aug 1, 2024

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Documentation content changes
  • Other... Please describe:

Other Information

Initially, we mirrored the SAP Build Code booster. However, for the current mission, not all service instances are needed. Thus, split up the terraform scripts into:

  • full_setup_enterprise: contains the full SAP Build Code Booster functionality as terraform script for enterprise accounts.
  • minimal_setup_enterprise: minimal service instances required for completing the mission in enterprise account.
  • minimal_setup_trial: minimal service instances required for completing the mission in trial account. Does not set up any subaccounts or CF environment, since this comes set up with the trial account.

@CHERIANS CHERIANS requested a review from prajin-op August 5, 2024 08:32
Copy link
Contributor

@prajin-op prajin-op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@CHERIANS
Copy link
Contributor

CHERIANS commented Aug 6, 2024

@johanneseschrig can you also update BTP terraform Provider version to 1.5.0 when you fix the merge conflicts.

@johanneseschrig
Copy link
Contributor Author

@johanneseschrig can you also update BTP terraform Provider version to 1.5.0 when you fix the merge conflicts.

I also bumped SAP/cloudfoundry to 1.0.0-rc1

@prajin-op prajin-op merged commit e515ebd into SAP-samples:main Aug 6, 2024
3 checks passed
@johanneseschrig johanneseschrig deleted the feature/build-code-mission branch August 6, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants