Skip to content

Improve outputs of DC missions 3061 and 3248 for QAS #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Improve outputs of DC missions 3061 and 3248 for QAS #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3a50cf
Add output to mission 3248
markusbalsam Jul 23, 2024
7709c84
Output values for ABAP missions (3061, 3248)
markusbalsam Jul 23, 2024
411cb4a
fix format
markusbalsam Jul 23, 2024
f361110
fix fmt
markusbalsam Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions released/discovery_center/mission_3061/step2/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,18 @@ resource "cloudfoundry_service_instance" "abap_si" {
###
# Creation of service key for ABAP Development Tools (ADT)
###
resource "cloudfoundry_service_credential_binding" "scb1" {
resource "cloudfoundry_service_credential_binding" "abap_adt_key" {
type = "key"
name = "${var.abap_sid}_adtkey"
name = "${var.abap_sid}_adt_key"
service_instance = cloudfoundry_service_instance.abap_si.id
}

###
# Creation of service key for COMM Arrangement
###
resource "cloudfoundry_service_credential_binding" "abap_ipskey" {
resource "cloudfoundry_service_credential_binding" "abap_ips_key" {
type = "key"
name = "${var.abap_sid}_ipskey"
name = "${var.abap_sid}_ips_key"
service_instance = cloudfoundry_service_instance.abap_si.id
parameters = jsonencode({
scenario_id = "SAP_COM_0193"
Expand Down
19 changes: 19 additions & 0 deletions released/discovery_center/mission_3061/step2/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
output "abab_service_instance_id" {
value = cloudfoundry_service_instance.abap_si.id
description = "The ID of the ABAP service instance."
}

output "abap_dashboard_url" {
value = cloudfoundry_service_instance.abap_si.dashboard_url
description = "The URL of the ABAP service instance dashboard."
}

output "abab_adt_key_id" {
value = cloudfoundry_service_credential_binding.abap_adt_key.id
description = "The ID of the ABAP service key for ADT."
}

output "abab_ips_key_id" {
value = cloudfoundry_service_credential_binding.abap_ips_key.id
description = "The ID of the ABAP service key for COMM Arrangement."
}
5 changes: 5 additions & 0 deletions released/discovery_center/mission_3248_trial/step2/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ output "abab_trial_service_instance_id" {
description = "The ID of the ABAP service instance."
}

output "abap_trial_dashboard_url" {
value = cloudfoundry_service_instance.abap_trial.dashboard_url
description = "The URL of the ABAP Trial dashboard."
}

output "abab_trial_service_key_id" {
value = cloudfoundry_service_credential_binding.abap_trial_service_key.id
description = "The ID of the ABAP service key."
Expand Down