Adopt DC mission 4441 (SAP Build Code) to correspond to Booster #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johanneseschrig
commented
Jul 15, 2024
| @@ -94,7 +101,7 @@ resource "btp_subaccount_entitlement" "destination" { | |||
| service_name = "destination" | |||
There was a problem hiding this comment.
@rui1610 I'm assuming we can't create the cicd destination without the destination service instance? I couldn't find the respective terraform BTP resource.
markusbalsam
suggested changes
Jul 16, 2024
There was a problem hiding this comment.
Hi @johanneseschrig, I see that you made the changes in thereleased/usecases/services_apps/sap_build_code folder but @rui1610 had created a new folder for the mission here released/discovery_center/mission_4441 with his PR (#233).
|
@markusbalsam sorry, fixed. |
markusbalsam
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
LGTM. I don't have sufficient privileges for this repo to approve PRs so that the merge is unblocked. @lechnerc77, @rui1610 can you please give final approval?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Pull Request Type
What kind of change does this Pull Request introduce?
Other Information