Skip to content

Naming conventions fix for mission 3680 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2024
Merged

Naming conventions fix for mission 3680 #259

merged 4 commits into from
Jul 16, 2024

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Jul 12, 2024

Purpose

  • Adds smaller fixes to comply with naming convention.
  • Adds the hana_tools url to the output

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

@rui1610 rui1610 enabled auto-merge (squash) July 12, 2024 11:08
lechnerc77
lechnerc77 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rui1610 rui1610 merged commit 2edb44f into main Jul 16, 2024
3 checks passed
@rui1610 rui1610 deleted the conventions_fix_mission3680 branch July 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

@mahesh0431 mahesh0431 Awaiting requested review from mahesh0431

@vipinvkmenon vipinvkmenon Awaiting requested review from vipinvkmenon

@CHERIANS CHERIANS Awaiting requested review from CHERIANS

@markusbalsam markusbalsam Awaiting requested review from markusbalsam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rui1610 @lechnerc77