Skip to content

clean-up code for usage in quick-account-setup (mission 3260) #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2024
Merged

clean-up code for usage in quick-account-setup (mission 3260) #245

merged 5 commits into from
Jul 10, 2024

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Jul 9, 2024

Purpose

  • clean-up mission 3260 (remove dependency to modules)
  • make the code fit to use in quick-account-setup in SAP Discovery Center.

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

@rui1610 rui1610 requested a review from lechnerc77 July 9, 2024 09:13
@rui1610
Copy link
Contributor Author

rui1610 commented Jul 9, 2024

Would like to have as well feedback from Markus Balsam and from Navya (mission owner). Waiting for them to share their GitHub users with me.

@rui1610 rui1610 requested a review from navyakhurana July 9, 2024 10:17
@rui1610 rui1610 changed the title clean-up code for usage in quick-account-setup clean-up code for usage in quick-account-setup (mission 3260) Jul 9, 2024
@rui1610 rui1610 requested a review from markusbalsam July 9, 2024 11:54
markusbalsam
markusbalsam suggested changes Jul 9, 2024
View reviewed changes
@rui1610 rui1610 requested a review from markusbalsam July 9, 2024 13:37
navyakhurana
navyakhurana approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@navyakhurana navyakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@rui1610 rui1610 requested review from vipinvkmenon and CHERIANS July 10, 2024 06:52
@rui1610 rui1610 merged commit 8201a77 into main Jul 10, 2024
3 checks passed
@rui1610 rui1610 deleted the mission3260_cleanup_qas branch July 10, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navyakhurana navyakhurana navyakhurana approved these changes

@markusbalsam markusbalsam markusbalsam approved these changes

@lechnerc77 lechnerc77 Awaiting requested review from lechnerc77

@vipinvkmenon vipinvkmenon Awaiting requested review from vipinvkmenon

@CHERIANS CHERIANS Awaiting requested review from CHERIANS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rui1610 @navyakhurana @markusbalsam