Skip to content

Add DC mission 3488 (SAC) #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 11, 2024
Merged

Add DC mission 3488 (SAC) #223

merged 24 commits into from
Jul 11, 2024

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Jun 28, 2024

Purpose

  • This PR adds the SAP Discovery Center mission 3488 (SAP Analytics Cloud) to the repo.

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

@rui1610 rui1610 marked this pull request as draft June 28, 2024 13:20
@rui1610 rui1610 changed the title Add DC mission 3488 Add DC mission 3488 (SAC) Jul 4, 2024
@rui1610 rui1610 marked this pull request as ready for review July 9, 2024 08:26
@rui1610 rui1610 requested a review from lechnerc77 July 9, 2024 08:27
@rui1610
Copy link
Contributor Author

rui1610 commented Jul 9, 2024

Currently having a folder "nocf" with the code that is not needing a Cloudfoundry instance.

@rui1610 rui1610 enabled auto-merge (squash) July 9, 2024 08:28
@rui1610 rui1610 requested a review from gdsap July 10, 2024 12:26
@gdsap
Copy link
Contributor

gdsap commented Jul 11, 2024

Done

@rui1610 rui1610 removed the request for review from lechnerc77 July 11, 2024 08:31
@rui1610 rui1610 disabled auto-merge July 11, 2024 08:32
@rui1610 rui1610 merged commit 5a3c43d into main Jul 11, 2024
3 checks passed
@rui1610 rui1610 deleted the dcmission_3488 branch July 11, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsap gdsap gdsap approved these changes

@markusbalsam markusbalsam Awaiting requested review from markusbalsam

@CHERIANS CHERIANS Awaiting requested review from CHERIANS

@vipinvkmenon vipinvkmenon Awaiting requested review from vipinvkmenon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rui1610 @gdsap @markusbalsam