Skip to content

Add SAP Build Code use case #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jun 11, 2024
Merged

Add SAP Build Code use case #188

merged 46 commits into from
Jun 11, 2024

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Jun 10, 2024

Purpose

  • This PR adds the creation of an SAP Build Code instance in a subaccount including all necessary subscriptions and service instances

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

rui1610 added 29 commits May 2, 2024 13:19
@rui1610
initial commit
364c63f
@rui1610
add entitlements
94f0404
@rui1610
add apps and services + cf
d3405af
@rui1610
update tf provider version
a9ea0e2
@rui1610
start working on cf part
7e7fc9c
@rui1610
add role assignments
33e2600
@rui1610
add role assignments
7bc35ca
@rui1610
finish step1 including tfvars for step2
f57313e
@rui1610
optimize output from step1 for step2
7d853c5
@rui1610
add origin
e5449b8
@rui1610
add keys
1b19f47
@rui1610
add destination
ac6bb1d
@rui1610
remove old artefacts
1d84bb0
@rui1610
comment out destination
0cc73e4
@rui1610
remove no longer needed app subscriptions
e3e8a83
@rui1610
add role collections
54b3af5
@rui1610
add subaccount administrator
caeb224
@rui1610
fix issues in service instance creation
e8ef6f2
@rui1610
remove dependency to cf for cicd service instance
79d9dca
@rui1610
make tf scripts more restrictive wrt "depends_on"
fda7e0a
@rui1610
update comments and slightly change command sequence
e25ce7a
@rui1610
add test for ci cd service setup
4e59251
@rui1610
fix cicd issue
770e027
@rui1610
add space developer role to "depends_on" for service instance creation
6b153f8
@rui1610
replace null_ressource with terraform_data
b104803
@rui1610
update CF documentation
f65dd51
@rui1610
update formatting
a8a0aa0
@rui1610
remove creation of terraform.tfvars file in step2 folder + add docume…
9a47cc5 
…ntation how to create tfvars file
@rui1610
format outputs
d286604
lechnerc77
lechnerc77 requested changes Jun 10, 2024
View reviewed changes
rui1610 and others added 16 commits June 10, 2024 13:37
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
af0fbeb 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610
remove validation of region
60c3215
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step2/variables.tf
ae80394 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step2/variables.tf
8207f38 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/main.tf
48a6bfb 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
3581987 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
9d0a0bd 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610
fix comment issue
ec5511f
@rui1610
add switch to create tfvars file for step 2
93a0e9d
@rui1610
Merge branch 'main' into sap-build-code
886213c
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
7bc22bd 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
533f0fb 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
cc30352 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
0d149a0 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step1/variables.tf
126d512 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
@rui1610 @lechnerc77
Update released/usecases/services_apps/sap_build_code/step2/variables.tf
46002ce 
Co-authored-by: Christian Lechner <lechnerc77@users.noreply.github.com>
rui1610
rui1610 commented Jun 11, 2024
View reviewed changes
Copy link
Contributor Author

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback! Addressed most of your comments already.

@rui1610 rui1610 requested a review from lechnerc77 June 11, 2024 13:54
@lechnerc77 lechnerc77 merged commit f5b9f34 into main Jun 11, 2024
3 checks passed
@lechnerc77 lechnerc77 deleted the sap-build-code branch June 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rui1610 @lechnerc77