Skip to content

The first version of Kyma mission 3252 terraform script #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

jacekon
Copy link
Contributor

@jacekon jacekon commented Jun 6, 2024

Purpose

The first version of Kyma mission 3252 terraform script.
It's locally working. Creates a subaccount and enables Kyma.

Pull Request Type

[ ] Bugfix
[x] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

Copy link

cla-assistant bot commented Jun 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jun 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some points in the files that need rework

Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit 1605b52 into SAP-samples:main Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants