der: add DecodeValueExt trait with fn from_der_value
#1936
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure the solution is a trait method exposed everywhere |
dishmaker
force-pushed
the
dishmaker/der_from_der_value
branch
from
87100ff to
6f03ef8
Compare
dishmaker
changed the title
DecodeValue::from_der_valueDecodeValueExt trait with fn from_der_value
|
I don't like the introduction of a trait to solve this very niche ergonomic issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I didn't know about
trick, when writing https://github.com/RustCrypto/crypto-bigint/pull/851/files#diff-87fe87bbce5380197d3c659465e30daf47af5cac570bb4058f467a5b2dffa0b2R164