der: auto read_nested in trait: DecodeValue::decode_value_nested
#1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what the goal of this PR is. I think there's some potential merit to this statement, but it also seems unrelated to this PR:
I played with that in |
|
The main goal is to optimize read_nested where it isn't necessary (e.g. primitive octet string). But that probably wouldn't happen, because encoding_rules is a runtime value. |
|
Because this PR is premature optimization, I'll leave it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a step towards removing overhead of
read_nestedfor primitive types, that was introduced in #1877.I think
reader.encoding_rules()should be generic, so BERread_nestedwould optimize out during compile time.