fix leak of temporary GL context on windows #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prokopyl
force-pushed
the
fix-gl-context-leak
branch
from
8620182 to
8b27675
Compare
prokopyl
approved these changes
Dec 5, 2024
Quant1um
added a commit
to blepfx/baseview
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a modern OpenGL context on Windows requires first creating a temporary context, using it to load some function pointers (e.g.
wglCreateContextAttribsARB), and then using those to create the actual context. In Baseview's case, the temporary context was not being deleted afterwards, resulting in a resource leak.