defer certain events on macOS to avoid re-entrant calls #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prokopyl
requested changes
May 12, 2024
Tested on MacOS Ventura using Reaper, and it is working great 🙂👍 |
micahrj
reviewed
May 13, 2024
prokopyl
previously requested changes
May 13, 2024
|
Any reason this is not being merged? I have been using these changes since May with no issues. |
micahrj
requested changes
Dec 5, 2024
micahrj
approved these changes
Dec 9, 2024
micahrj
dismissed
prokopyl’s stale review
requested changes have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, calling
window.focus()would cause a crash in some scenarios, because certain members ofWindowStatewere borrowed mutably while already being borrowed. this PR fixes the issue by deferring window focus events to be triggered before callingWindowHandler:on_frame().