Skip to content

Commit f8d6ff4

Browse files
committed
Merge tag 'nfsd-6.5-5' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
Pull nfsd fixes from Chuck Lever: "Two last-minute one-liners for v6.5-rc. One got lost in the shuffle, and the other was reported just this morning" - Close race window when handling FREE_STATEID operations - Fix regression in /proc/fs/nfsd/v4_end_grace introduced in v6.5-rc" * tag 'nfsd-6.5-5' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux: NFSD: Fix a thinko introduced by recent trace point changes nfsd: Fix race to FREE_STATEID and cl_revoked
2 parents 0de5ec4 + 8073a98 commit f8d6ff4

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

fs/nfsd/nfs4state.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1354,9 +1354,9 @@ static void revoke_delegation(struct nfs4_delegation *dp)
13541354
trace_nfsd_stid_revoke(&dp->dl_stid);
13551355

13561356
if (clp->cl_minorversion) {
1357+
spin_lock(&clp->cl_lock);
13571358
dp->dl_stid.sc_type = NFS4_REVOKED_DELEG_STID;
13581359
refcount_inc(&dp->dl_stid.sc_count);
1359-
spin_lock(&clp->cl_lock);
13601360
list_add(&dp->dl_recall_lru, &clp->cl_revoked);
13611361
spin_unlock(&clp->cl_lock);
13621362
}

fs/nfsd/nfsctl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,6 +1105,7 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size)
11051105
if (!nn->nfsd_serv)
11061106
return -EBUSY;
11071107
trace_nfsd_end_grace(netns(file));
1108+
nfsd4_end_grace(nn);
11081109
break;
11091110
default:
11101111
return -EINVAL;

0 commit comments

Comments
 (0)