Skip to content

Commit f41b402

Browse files
martinetdericvh
authored andcommitted
9p: virtio: skip incrementing unused variable
Fix the following scan-build warning: net/9p/trans_virtio.c:504:3: warning: Value stored to 'in' is never read [deadcode.DeadStores] in += pack_sg_list_p(chan->sg, out + in, VIRTQUEUE_NUM, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I'm honestly not 100% sure about this one; I'm tempted to think we could (should?) just check the return value of pack_sg_list_p to skip the in_sgs++ and setting sgs[] if it didn't process anything, but I'm not sure it should ever happen so this is probably fine as is. Just removing the assignment at least makes it clear the return value isn't used, so it's an improvement in terms of readability. Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
1 parent 4a73eda commit f41b402

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/9p/trans_virtio.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,8 +501,8 @@ p9_virtio_zc_request(struct p9_client *client, struct p9_req_t *req,
501501

502502
if (in_pages) {
503503
sgs[out_sgs + in_sgs++] = chan->sg + out + in;
504-
in += pack_sg_list_p(chan->sg, out + in, VIRTQUEUE_NUM,
505-
in_pages, in_nr_pages, offs, inlen);
504+
pack_sg_list_p(chan->sg, out + in, VIRTQUEUE_NUM,
505+
in_pages, in_nr_pages, offs, inlen);
506506
}
507507

508508
BUG_ON(out_sgs + in_sgs > ARRAY_SIZE(sgs));

0 commit comments

Comments
 (0)