Skip to content

Commit 4a73eda

Browse files
martinetdericvh
authored andcommitted
9p: virtio: make sure 'offs' is initialized in zc_request
Similarly to the previous patch: offs can be used in handle_rerrors without initializing on small payloads; in this case handle_rerrors will not use it because of the size check, but it doesn't hurt to make sure it is zero to please scan-build. This fixes the following warning: net/9p/trans_virtio.c:539:3: warning: 3rd function call argument is an uninitialized value [core.CallAndMessage] handle_rerror(req, in_hdr_len, offs, in_pages); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
1 parent 13ade4a commit 4a73eda

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/9p/trans_virtio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ p9_virtio_zc_request(struct p9_client *client, struct p9_req_t *req,
428428
struct page **in_pages = NULL, **out_pages = NULL;
429429
struct virtio_chan *chan = client->trans;
430430
struct scatterlist *sgs[4];
431-
size_t offs;
431+
size_t offs = 0;
432432
int need_drop = 0;
433433
int kicked = 0;
434434

0 commit comments

Comments
 (0)