Skip to content

Commit eb30ad4

Browse files
committed
Merge branch 'pci/controller/remove-void-return'
- Convert exynos, keystone, kirin from .remove() to .remove_new(), which returns void instead of int (Uwe Kleine-König) * pci/controller/remove-void-return: PCI: kirin: Convert to platform remove callback returning void PCI: keystone: Convert to platform remove callback returning void PCI: exynos: Convert to platform remove callback returning void
2 parents fd286a1 + a5eee68 commit eb30ad4

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

drivers/pci/controller/dwc/pci-exynos.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ static int exynos_pcie_probe(struct platform_device *pdev)
375375
return ret;
376376
}
377377

378-
static int exynos_pcie_remove(struct platform_device *pdev)
378+
static void exynos_pcie_remove(struct platform_device *pdev)
379379
{
380380
struct exynos_pcie *ep = platform_get_drvdata(pdev);
381381

@@ -385,8 +385,6 @@ static int exynos_pcie_remove(struct platform_device *pdev)
385385
phy_exit(ep->phy);
386386
exynos_pcie_deinit_clk_resources(ep);
387387
regulator_bulk_disable(ARRAY_SIZE(ep->supplies), ep->supplies);
388-
389-
return 0;
390388
}
391389

392390
static int exynos_pcie_suspend_noirq(struct device *dev)
@@ -431,7 +429,7 @@ static const struct of_device_id exynos_pcie_of_match[] = {
431429

432430
static struct platform_driver exynos_pcie_driver = {
433431
.probe = exynos_pcie_probe,
434-
.remove = exynos_pcie_remove,
432+
.remove_new = exynos_pcie_remove,
435433
.driver = {
436434
.name = "exynos-pcie",
437435
.of_match_table = exynos_pcie_of_match,

drivers/pci/controller/dwc/pci-keystone.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1311,7 +1311,7 @@ static int ks_pcie_probe(struct platform_device *pdev)
13111311
return ret;
13121312
}
13131313

1314-
static int ks_pcie_remove(struct platform_device *pdev)
1314+
static void ks_pcie_remove(struct platform_device *pdev)
13151315
{
13161316
struct keystone_pcie *ks_pcie = platform_get_drvdata(pdev);
13171317
struct device_link **link = ks_pcie->link;
@@ -1323,13 +1323,11 @@ static int ks_pcie_remove(struct platform_device *pdev)
13231323
ks_pcie_disable_phy(ks_pcie);
13241324
while (num_lanes--)
13251325
device_link_del(link[num_lanes]);
1326-
1327-
return 0;
13281326
}
13291327

13301328
static struct platform_driver ks_pcie_driver = {
13311329
.probe = ks_pcie_probe,
1332-
.remove = ks_pcie_remove,
1330+
.remove_new = ks_pcie_remove,
13331331
.driver = {
13341332
.name = "keystone-pcie",
13351333
.of_match_table = ks_pcie_of_match,

drivers/pci/controller/dwc/pcie-kirin.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -738,15 +738,13 @@ static int kirin_pcie_power_on(struct platform_device *pdev,
738738
return ret;
739739
}
740740

741-
static int kirin_pcie_remove(struct platform_device *pdev)
741+
static void kirin_pcie_remove(struct platform_device *pdev)
742742
{
743743
struct kirin_pcie *kirin_pcie = platform_get_drvdata(pdev);
744744

745745
dw_pcie_host_deinit(&kirin_pcie->pci->pp);
746746

747747
kirin_pcie_power_off(kirin_pcie);
748-
749-
return 0;
750748
}
751749

752750
struct kirin_pcie_data {
@@ -815,7 +813,7 @@ static int kirin_pcie_probe(struct platform_device *pdev)
815813

816814
static struct platform_driver kirin_pcie_driver = {
817815
.probe = kirin_pcie_probe,
818-
.remove = kirin_pcie_remove,
816+
.remove_new = kirin_pcie_remove,
819817
.driver = {
820818
.name = "kirin-pcie",
821819
.of_match_table = kirin_pcie_match,

0 commit comments

Comments
 (0)