Skip to content

Commit fd286a1

Browse files
committed
Merge branch 'pci/controller/xilinx'
- Remove redundant dev_err(), since platform_get_irq() and platform_get_irq_byname() already log errors (Yang Li) - Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq() (Krzysztof Wilczyński) - Fix xilinx_pl_dma_pcie_init_irq_domain() error return when irq_domain_add_linear() fails (Harshit Mogalapalli) * pci/controller/xilinx: PCI: xilinx-xdma: Fix error code in xilinx_pl_dma_pcie_init_irq_domain() PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq() PCI: xilinx-xdma: Remove redundant dev_err()
2 parents 161d42d + 2324be1 commit fd286a1

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

drivers/pci/controller/pcie-xilinx-dma-pl.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ static int xilinx_pl_dma_pcie_init_irq_domain(struct pl_dma_pcie *port)
576576
&intx_domain_ops, port);
577577
if (!port->intx_domain) {
578578
dev_err(dev, "Failed to get a INTx IRQ domain\n");
579-
return PTR_ERR(port->intx_domain);
579+
return -ENOMEM;
580580
}
581581

582582
irq_domain_update_bus_token(port->intx_domain, DOMAIN_BUS_WIRED);
@@ -635,14 +635,14 @@ static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port)
635635
err = devm_request_irq(dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,
636636
IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
637637
if (err) {
638-
dev_err(dev, "Failed to request INTx IRQ %d\n", irq);
638+
dev_err(dev, "Failed to request INTx IRQ %d\n", port->intx_irq);
639639
return err;
640640
}
641641

642642
err = devm_request_irq(dev, port->irq, xilinx_pl_dma_pcie_event_flow,
643643
IRQF_SHARED | IRQF_NO_THREAD, NULL, port);
644644
if (err) {
645-
dev_err(dev, "Failed to request event IRQ %d\n", irq);
645+
dev_err(dev, "Failed to request event IRQ %d\n", port->irq);
646646
return err;
647647
}
648648

@@ -684,10 +684,8 @@ static int xilinx_request_msi_irq(struct pl_dma_pcie *port)
684684
int ret;
685685

686686
port->msi.irq_msi0 = platform_get_irq_byname(pdev, "msi0");
687-
if (port->msi.irq_msi0 <= 0) {
688-
dev_err(dev, "Unable to find msi0 IRQ line\n");
687+
if (port->msi.irq_msi0 <= 0)
689688
return port->msi.irq_msi0;
690-
}
691689

692690
ret = devm_request_irq(dev, port->msi.irq_msi0, xilinx_pl_dma_pcie_msi_handler_low,
693691
IRQF_SHARED | IRQF_NO_THREAD, "xlnx-pcie-dma-pl",
@@ -698,10 +696,8 @@ static int xilinx_request_msi_irq(struct pl_dma_pcie *port)
698696
}
699697

700698
port->msi.irq_msi1 = platform_get_irq_byname(pdev, "msi1");
701-
if (port->msi.irq_msi1 <= 0) {
702-
dev_err(dev, "Unable to find msi1 IRQ line\n");
699+
if (port->msi.irq_msi1 <= 0)
703700
return port->msi.irq_msi1;
704-
}
705701

706702
ret = devm_request_irq(dev, port->msi.irq_msi1, xilinx_pl_dma_pcie_msi_handler_high,
707703
IRQF_SHARED | IRQF_NO_THREAD, "xlnx-pcie-dma-pl",

0 commit comments

Comments
 (0)