Skip to content

Commit e4e40a8

Browse files
irengerleon
authored andcommitted
RDMA/ipoib: Remove NULL check before dev_{put, hold}
Coccinelle reports a warning WARNING: NULL check before dev_{put, hold} functions is not needed The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL There is no need to check before using dev_{put, hold} Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Link: https://lore.kernel.org/r/ZjGDFatHRMI6Eg7M@octinomon.home Signed-off-by: Leon Romanovsky <leon@kernel.org>
1 parent 82e9661 commit e4e40a8

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/infiniband/ulp/ipoib/ipoib_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,7 @@ static struct net_device *ipoib_get_master_net_dev(struct net_device *dev)
329329

330330
rcu_read_lock();
331331
master = netdev_master_upper_dev_get_rcu(dev);
332-
if (master)
333-
dev_hold(master);
332+
dev_hold(master);
334333
rcu_read_unlock();
335334

336335
if (master)

0 commit comments

Comments
 (0)