Skip to content

Commit 82e9661

Browse files
irengerleon
authored andcommitted
RDMA/mlx5: Remove NULL check before dev_{put, hold}
Coccinelle reports a warning WARNING: NULL check before dev_{put, hold} functions is not needed The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL There is no need to check before using dev_{put, hold} Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Link: https://lore.kernel.org/r/ZjGC4qXrOwZE0aHi@octinomon.home Signed-off-by: Leon Romanovsky <leon@kernel.org>
1 parent fd3af5e commit 82e9661

File tree

1 file changed

+1
-2
lines changed
  • drivers/infiniband/hw/mlx5

1 file changed

+1
-2
lines changed

drivers/infiniband/hw/mlx5/main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,7 @@ static struct net_device *mlx5_ib_get_netdev(struct ib_device *device,
264264
*/
265265
read_lock(&ibdev->port[port_num - 1].roce.netdev_lock);
266266
ndev = ibdev->port[port_num - 1].roce.netdev;
267-
if (ndev)
268-
dev_hold(ndev);
267+
dev_hold(ndev);
269268
read_unlock(&ibdev->port[port_num - 1].roce.netdev_lock);
270269

271270
out:

0 commit comments

Comments
 (0)