Skip to content

Commit c9b2572

Browse files
ffainellilinusw
authored andcommitted
pinctrl: nsp-gpio: Silence probe deferral messages
We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Dhruva Gole <d-gole@ti.com> Link: https://lore.kernel.org/r/20230808180733.2081353-3-florian.fainelli@broadcom.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent d2606a6 commit c9b2572

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/pinctrl/bcm/pinctrl-nsp-gpio.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -685,10 +685,8 @@ static int nsp_gpio_probe(struct platform_device *pdev)
685685
}
686686

687687
ret = devm_gpiochip_add_data(dev, gc, chip);
688-
if (ret < 0) {
689-
dev_err(dev, "unable to add GPIO chip\n");
690-
return ret;
691-
}
688+
if (ret < 0)
689+
return dev_err_probe(dev, ret, "unable to add GPIO chip\n");
692690

693691
ret = nsp_gpio_register_pinconf(chip);
694692
if (ret) {

0 commit comments

Comments
 (0)