Skip to content

Commit d2606a6

Browse files
ffainellilinusw
authored andcommitted
pinctrl: iproc-gpio: Silence probe deferral messages
We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Dhruva Gole <d-gole@ti.com> Link: https://lore.kernel.org/r/20230808180733.2081353-2-florian.fainelli@broadcom.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 0cec950 commit d2606a6

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/pinctrl/bcm/pinctrl-iproc-gpio.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -891,10 +891,8 @@ static int iproc_gpio_probe(struct platform_device *pdev)
891891
}
892892

893893
ret = gpiochip_add_data(gc, chip);
894-
if (ret < 0) {
895-
dev_err(dev, "unable to add GPIO chip\n");
896-
return ret;
897-
}
894+
if (ret < 0)
895+
return dev_err_probe(dev, ret, "unable to add GPIO chip\n");
898896

899897
if (!no_pinconf) {
900898
ret = iproc_gpio_register_pinconf(chip);

0 commit comments

Comments
 (0)