Skip to content

Commit bd8aa15

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: x86: Clean up Asus entries in acpi_quirk_skip_dmi_ids[]
The Asus entries in the acpi_quirk_skip_dmi_ids[] table are the only entries without a comment which model they apply to. Add these comments. The Asus TF103C entry also is in the wrong place for what is supposed to be an alphabetically sorted list. Move it up so that the list is properly sorted and add a comment that the list is alphabetically sorted. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://patch.msgid.link/20241116095825.11660-2-hdegoede@redhat.com [ rjw: Changelog and subject edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 82f250e commit bd8aa15

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

drivers/acpi/x86/utils.c

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,7 @@ static const struct dmi_system_id acpi_quirk_skip_dmi_ids[] = {
296296
/*
297297
* 2. Devices which also have the skip i2c/serdev quirks and which
298298
* need the x86-android-tablets module to properly work.
299+
* Sorted alphabetically.
299300
*/
300301
#if IS_ENABLED(CONFIG_X86_ANDROID_TABLETS)
301302
{
@@ -321,6 +322,7 @@ static const struct dmi_system_id acpi_quirk_skip_dmi_ids[] = {
321322
ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
322323
},
323324
{
325+
/* Asus ME176C tablet */
324326
.matches = {
325327
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
326328
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ME176C"),
@@ -331,23 +333,24 @@ static const struct dmi_system_id acpi_quirk_skip_dmi_ids[] = {
331333
ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
332334
},
333335
{
334-
/* Lenovo Yoga Book X90F/L */
336+
/* Asus TF103C transformer 2-in-1 */
335337
.matches = {
336-
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
337-
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
338-
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"),
338+
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
339+
DMI_MATCH(DMI_PRODUCT_NAME, "TF103C"),
339340
},
340341
.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
341-
ACPI_QUIRK_UART1_SKIP |
342342
ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
343343
ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
344344
},
345345
{
346+
/* Lenovo Yoga Book X90F/L */
346347
.matches = {
347-
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
348-
DMI_MATCH(DMI_PRODUCT_NAME, "TF103C"),
348+
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
349+
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
350+
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"),
349351
},
350352
.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
353+
ACPI_QUIRK_UART1_SKIP |
351354
ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
352355
ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
353356
},

0 commit comments

Comments
 (0)