Skip to content

Commit 82f250e

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: x86: Add skip i2c clients quirk for Acer Iconia One 8 A1-840
The Acer Iconia One 8 A1-840 (not to be confused with the A1-840FHD which is a different model) ships with Android 4.4 as factory OS and has the usual broken DSDT issues for x86 Android tablets. Add quirks to skip ACPI I2C client enumeration and disable ACPI battery/AC and ACPI GPIO event handlers. Also add the "INT33F5" HID for the TI PMIC used on this tablet to the list of HIDs for which not to skip i2c_client instantiation, since we do want an ACPI instantiated i2c_client for the PMIC. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://patch.msgid.link/20241116095825.11660-1-hdegoede@redhat.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 4e9ad03 commit 82f250e

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

drivers/acpi/x86/utils.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,18 @@ static const struct dmi_system_id acpi_quirk_skip_dmi_ids[] = {
308308
ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
309309
ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
310310
},
311+
{
312+
/* Acer Iconia One 8 A1-840 (non FHD version) */
313+
.matches = {
314+
DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
315+
DMI_MATCH(DMI_PRODUCT_NAME, "BayTrail"),
316+
/* Above strings are too generic also match BIOS date */
317+
DMI_MATCH(DMI_BIOS_DATE, "04/01/2014"),
318+
},
319+
.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
320+
ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
321+
ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
322+
},
311323
{
312324
.matches = {
313325
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
@@ -425,6 +437,7 @@ static const struct acpi_device_id i2c_acpi_known_good_ids[] = {
425437
{ "10EC5640", 0 }, /* RealTek ALC5640 audio codec */
426438
{ "10EC5651", 0 }, /* RealTek ALC5651 audio codec */
427439
{ "INT33F4", 0 }, /* X-Powers AXP288 PMIC */
440+
{ "INT33F5", 0 }, /* TI Dollar Cove PMIC */
428441
{ "INT33FD", 0 }, /* Intel Crystal Cove PMIC */
429442
{ "INT34D3", 0 }, /* Intel Whiskey Cove PMIC */
430443
{ "NPCE69A", 0 }, /* Asus Transformer keyboard dock */

0 commit comments

Comments
 (0)