Skip to content

Commit a29b2fc

Browse files
geertubebarino
authored andcommitted
clk: imx93: Propagate correct error in imx93_clocks_probe()
smatch reports: drivers/clk/imx/clk-imx93.c:294 imx93_clocks_probe() error: uninitialized symbol 'base'. Indeed, in case of an error, the wrong (yet uninitialized) variable is converted to an error code and returned. Fix this by propagating the error code in the correct variable. Fixes: e02ba11 ("clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/9c2acd81-3ad8-485d-819e-9e4201277831@kadam.mountain Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/all/202306161533.4YDmL22b-lkp@intel.com/ Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20230711150812.3562221-1-geert+renesas@glider.be Reviewed-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 1eb8d61 commit a29b2fc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/clk/imx/clk-imx93.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ static int imx93_clocks_probe(struct platform_device *pdev)
291291
anatop_base = devm_of_iomap(dev, np, 0, NULL);
292292
of_node_put(np);
293293
if (WARN_ON(IS_ERR(anatop_base))) {
294-
ret = PTR_ERR(base);
294+
ret = PTR_ERR(anatop_base);
295295
goto unregister_hws;
296296
}
297297

0 commit comments

Comments
 (0)