Skip to content

Commit 8ebd16c

Browse files
fenghusthuPeter Zijlstra
authored andcommitted
perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map()
pci_get_device() will increase the reference count for the returned pci_dev, so snr_uncore_get_mc_dev() will return a pci_dev with its reference count increased. We need to call pci_dev_put() to decrease the reference count. Let's add the missing pci_dev_put(). Fixes: ee49532 ("perf/x86/intel/uncore: Add IMC uncore support for Snow Ridge") Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Link: https://lore.kernel.org/r/20221118063137.121512-4-wangxiongfeng2@huawei.com
1 parent 1ff9dd6 commit 8ebd16c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

arch/x86/events/intel/uncore_snbep.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5111,6 +5111,8 @@ static int snr_uncore_mmio_map(struct intel_uncore_box *box,
51115111

51125112
addr += box_ctl;
51135113

5114+
pci_dev_put(pdev);
5115+
51145116
box->io_addr = ioremap(addr, type->mmio_map_size);
51155117
if (!box->io_addr) {
51165118
pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name);

0 commit comments

Comments
 (0)