Skip to content

Commit 1ff9dd6

Browse files
fenghusthuPeter Zijlstra
authored andcommitted
perf/x86/intel/uncore: Fix reference count leak in hswep_has_limit_sbox()
pci_get_device() will increase the reference count for the returned 'dev'. We need to call pci_dev_put() to decrease the reference count. Since 'dev' is only used in pci_read_config_dword(), let's add pci_dev_put() right after it. Fixes: 9d48015 ("perf/x86/intel/uncore: Remove uncore extra PCI dev HSWEP_PCI_PCU_3") Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Link: https://lore.kernel.org/r/20221118063137.121512-3-wangxiongfeng2@huawei.com
1 parent c508eb0 commit 1ff9dd6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/x86/events/intel/uncore_snbep.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2910,6 +2910,7 @@ static bool hswep_has_limit_sbox(unsigned int device)
29102910
return false;
29112911

29122912
pci_read_config_dword(dev, HSWEP_PCU_CAPID4_OFFET, &capid4);
2913+
pci_dev_put(dev);
29132914
if (!hswep_get_chop(capid4))
29142915
return true;
29152916

0 commit comments

Comments
 (0)