Skip to content

Commit 7462e46

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/opa362: Don't put .remove() in .exit.text and drop suppress_bind_attrs
On today's platforms the memory savings of putting the remove function in .exit isn't that relevant any more. It only matters for built-in drivers and typically saves a few 100k. The downside is that the driver cannot be unbound at runtime which is ancient and also slightly complicates testing. Also it requires to mark the driver struct with __refdata which is needed to suppress a (W=1) modpost warning: WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410: section mismatch in reference: tfp410_driver+0x4 (section: .data) -> tfp410_remove (section: .exit.text) To simplify matters, move the remove callback to .text and drop .suppress_bind_attrs = true. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 1fc9ea0 commit 7462e46

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ static int opa362_probe(struct platform_device *pdev)
231231
return r;
232232
}
233233

234-
static int __exit opa362_remove(struct platform_device *pdev)
234+
static int opa362_remove(struct platform_device *pdev)
235235
{
236236
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
237237
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -260,11 +260,10 @@ MODULE_DEVICE_TABLE(of, opa362_of_match);
260260

261261
static struct platform_driver opa362_driver = {
262262
.probe = opa362_probe,
263-
.remove = __exit_p(opa362_remove),
263+
.remove = opa362_remove,
264264
.driver = {
265265
.name = "amplifier-opa362",
266266
.of_match_table = opa362_of_match,
267-
.suppress_bind_attrs = true,
268267
},
269268
};
270269

0 commit comments

Comments
 (0)