Skip to content

Commit 1fc9ea0

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/hdmi: Don't put .remove() in .exit.text and drop suppress_bind_attrs
On today's platforms the memory savings of putting the remove function in .exit isn't that relevant any more. It only matters for built-in drivers and typically saves a few 100k. The downside is that the driver cannot be unbound at runtime which is ancient and also slightly complicates testing. Also it requires to mark the driver struct with __refdata which is needed to suppress a (W=1) modpost warning: WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi: section mismatch in reference: hdmi_connector_driver+0x4 (section: .data) -> hdmic_remove (section: .exit.text) To simplify matters, move the remove callback to .text and drop .suppress_bind_attrs = true. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent f004d91 commit 1fc9ea0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ static int hdmic_probe(struct platform_device *pdev)
249249
return r;
250250
}
251251

252-
static int __exit hdmic_remove(struct platform_device *pdev)
252+
static int hdmic_remove(struct platform_device *pdev)
253253
{
254254
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
255255
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -274,11 +274,10 @@ MODULE_DEVICE_TABLE(of, hdmic_of_match);
274274

275275
static struct platform_driver hdmi_connector_driver = {
276276
.probe = hdmic_probe,
277-
.remove = __exit_p(hdmic_remove),
277+
.remove = hdmic_remove,
278278
.driver = {
279279
.name = "connector-hdmi",
280280
.of_match_table = hdmic_of_match,
281-
.suppress_bind_attrs = true,
282281
},
283282
};
284283

0 commit comments

Comments
 (0)