Skip to content

Commit 703e771

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: chromeos_acpi: support official HID GOOG0016
Support official HID GOOG0016 for ChromeOS ACPI (see [1]). [1]: https://crrev.com/c/2266713 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> Link: https://lore.kernel.org/r/20230731024214.908235-1-tzungbi@kernel.org Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
1 parent f2d4dce commit 703e771

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

Documentation/ABI/testing/sysfs-driver-chromeos-acpi

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
What: /sys/bus/platform/devices/GGL0001:*/BINF.2
2+
/sys/bus/platform/devices/GOOG0016:*/BINF.2
23
Date: May 2022
34
KernelVersion: 5.19
45
Description:
@@ -10,6 +11,7 @@ Description:
1011
== ===============================
1112

1213
What: /sys/bus/platform/devices/GGL0001:*/BINF.3
14+
/sys/bus/platform/devices/GOOG0016:*/BINF.3
1315
Date: May 2022
1416
KernelVersion: 5.19
1517
Description:
@@ -23,6 +25,7 @@ Description:
2325
== =====================================
2426

2527
What: /sys/bus/platform/devices/GGL0001:*/CHSW
28+
/sys/bus/platform/devices/GOOG0016:*/CHSW
2629
Date: May 2022
2730
KernelVersion: 5.19
2831
Description:
@@ -38,27 +41,31 @@ Description:
3841
==== ===========================================
3942

4043
What: /sys/bus/platform/devices/GGL0001:*/FMAP
44+
/sys/bus/platform/devices/GOOG0016:*/FMAP
4145
Date: May 2022
4246
KernelVersion: 5.19
4347
Description:
4448
Returns physical memory address of the start of the main
4549
processor firmware flashmap.
4650

4751
What: /sys/bus/platform/devices/GGL0001:*/FRID
52+
/sys/bus/platform/devices/GOOG0016:*/FRID
4853
Date: May 2022
4954
KernelVersion: 5.19
5055
Description:
5156
Returns firmware version for the read-only portion of the
5257
main processor firmware.
5358

5459
What: /sys/bus/platform/devices/GGL0001:*/FWID
60+
/sys/bus/platform/devices/GOOG0016:*/FWID
5561
Date: May 2022
5662
KernelVersion: 5.19
5763
Description:
5864
Returns firmware version for the rewritable portion of the
5965
main processor firmware.
6066

6167
What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.0
68+
/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.0
6269
Date: May 2022
6370
KernelVersion: 5.19
6471
Description:
@@ -73,6 +80,7 @@ Description:
7380
=========== ==================================
7481

7582
What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.1
83+
/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.1
7684
Date: May 2022
7785
KernelVersion: 5.19
7886
Description:
@@ -84,25 +92,29 @@ Description:
8492
== =======================
8593

8694
What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.2
95+
/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.2
8796
Date: May 2022
8897
KernelVersion: 5.19
8998
Description:
9099
Returns the GPIO number on the specified GPIO
91100
controller.
92101

93102
What: /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.3
103+
/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.3
94104
Date: May 2022
95105
KernelVersion: 5.19
96106
Description:
97107
Returns name of the GPIO controller.
98108

99109
What: /sys/bus/platform/devices/GGL0001:*/HWID
110+
/sys/bus/platform/devices/GOOG0016:*/HWID
100111
Date: May 2022
101112
KernelVersion: 5.19
102113
Description:
103114
Returns hardware ID for the Chromebook.
104115

105116
What: /sys/bus/platform/devices/GGL0001:*/MECK
117+
/sys/bus/platform/devices/GOOG0016:*/MECK
106118
Date: May 2022
107119
KernelVersion: 5.19
108120
Description:
@@ -113,6 +125,7 @@ Description:
113125
present, or if the firmware was unable to read the extended registers, this buffer size can be zero.
114126

115127
What: /sys/bus/platform/devices/GGL0001:*/VBNV.0
128+
/sys/bus/platform/devices/GOOG0016:*/VBNV.0
116129
Date: May 2022
117130
KernelVersion: 5.19
118131
Description:
@@ -122,13 +135,15 @@ Description:
122135
clock data).
123136

124137
What: /sys/bus/platform/devices/GGL0001:*/VBNV.1
138+
/sys/bus/platform/devices/GOOG0016:*/VBNV.1
125139
Date: May 2022
126140
KernelVersion: 5.19
127141
Description:
128142
Return the size in bytes of the verified boot non-volatile
129143
storage block.
130144

131145
What: /sys/bus/platform/devices/GGL0001:*/VDAT
146+
/sys/bus/platform/devices/GOOG0016:*/VDAT
132147
Date: May 2022
133148
KernelVersion: 5.19
134149
Description:

Documentation/firmware-guide/acpi/chromeos-acpi-device.rst

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@ Chrome OS ACPI Device
55
=====================
66

77
Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device.
8-
The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google.
9-
PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI
10-
objects are supported:
8+
The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is
9+
GOOG0016. The following ACPI objects are supported:
1110

1211
.. flat-table:: Supported ACPI Objects
1312
:widths: 1 2

drivers/platform/chrome/chromeos_acpi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,9 @@ static int chromeos_acpi_device_probe(struct platform_device *pdev)
235235
return 0;
236236
}
237237

238-
/* GGL is valid PNP ID of Google. PNP ID can be used with the ACPI devices. */
239238
static const struct acpi_device_id chromeos_device_ids[] = {
240239
{ "GGL0001", 0 },
240+
{ "GOOG0016", 0 },
241241
{}
242242
};
243243
MODULE_DEVICE_TABLE(acpi, chromeos_device_ids);

0 commit comments

Comments
 (0)