Skip to content

Commit f2d4dce

Browse files
rbbrnsTzung-Bi Shih
authored andcommitted
platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout
Remove the 1 second timeout applied to hw_protection_shutdown after an EC panic. On some platforms this 1 second timeout is insufficient to allow the filesystem to fully sync. Independently the EC will force a full system reset after a short period. So this backup timeout is unnecessary. Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> Link: https://lore.kernel.org/r/20230802175847.1.Ie9fc53b6a1f4c6661c5376286a50e0cf51b3e961@changeid Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
1 parent 5008b86 commit f2d4dce

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/platform/chrome/cros_ec_lpc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
327327
dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
328328
blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
329329
kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env);
330-
/* Begin orderly shutdown. Force shutdown after 1 second. */
331-
hw_protection_shutdown("CrOS EC Panic", 1000);
330+
/* Begin orderly shutdown. EC will force reset after a short period. */
331+
hw_protection_shutdown("CrOS EC Panic", -1);
332332
/* Do not query for other events after a panic is reported */
333333
return;
334334
}

0 commit comments

Comments
 (0)