Skip to content

Commit 6a06fc7

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/sharp-ls037v7dw01: Don't put .remove() in .exit.text and drop suppress_bind_attrs
On today's platforms the memory savings of putting the remove function in .exit isn't that relevant any more. It only matters for built-in drivers and typically saves a few 100k. The downside is that the driver cannot be unbound at runtime which is ancient and also slightly complicates testing. Also it requires to mark the driver struct with __refdata which is needed to suppress a (W=1) modpost warning: WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01: section mismatch in reference: sharp_ls_driver+0x4 (section: .data) -> sharp_ls_remove (section: .exit.text) To simplify matters, move the remove callback to .text and drop .suppress_bind_attrs = true. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 7462e46 commit 6a06fc7

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ static int sharp_ls_probe(struct platform_device *pdev)
292292
return r;
293293
}
294294

295-
static int __exit sharp_ls_remove(struct platform_device *pdev)
295+
static int sharp_ls_remove(struct platform_device *pdev)
296296
{
297297
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
298298
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -317,11 +317,10 @@ MODULE_DEVICE_TABLE(of, sharp_ls_of_match);
317317

318318
static struct platform_driver sharp_ls_driver = {
319319
.probe = sharp_ls_probe,
320-
.remove = __exit_p(sharp_ls_remove),
320+
.remove = sharp_ls_remove,
321321
.driver = {
322322
.name = "panel-sharp-ls037v7dw01",
323323
.of_match_table = sharp_ls_of_match,
324-
.suppress_bind_attrs = true,
325324
},
326325
};
327326

0 commit comments

Comments
 (0)