Skip to content

Commit 69a184f

Browse files
AnnYugawakuba-moo
authored andcommitted
ethernet: atheros: fix return value check in atl1e_tso_csum()
in atl1e_tso_csum, it should check the return value of pskb_trim(), and return an error code if an unexpected value is returned by pskb_trim(). Fixes: a6a5325 ("atl1e: Atheros L1E Gigabit Ethernet driver") Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Link: https://lore.kernel.org/r/20230720144219.39285-1-ruc_gongyuanjun@163.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ed96824 commit 69a184f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

drivers/net/ethernet/atheros/atl1e/atl1e_main.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1641,8 +1641,11 @@ static int atl1e_tso_csum(struct atl1e_adapter *adapter,
16411641
real_len = (((unsigned char *)ip_hdr(skb) - skb->data)
16421642
+ ntohs(ip_hdr(skb)->tot_len));
16431643

1644-
if (real_len < skb->len)
1645-
pskb_trim(skb, real_len);
1644+
if (real_len < skb->len) {
1645+
err = pskb_trim(skb, real_len);
1646+
if (err)
1647+
return err;
1648+
}
16461649

16471650
hdr_len = skb_tcp_all_headers(skb);
16481651
if (unlikely(skb->len == hdr_len)) {

0 commit comments

Comments
 (0)