Skip to content

Commit ed96824

Browse files
AnnYugawakuba-moo
authored andcommitted
atheros: fix return value check in atl1_tso()
in atl1_tso(), it should check the return value of pskb_trim(), and return an error code if an unexpected value is returned by pskb_trim(). Fixes: 401c0aa ("atl1: simplify tx packet descriptor") Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com> Link: https://lore.kernel.org/r/20230722142511.12448-1-ruc_gongyuanjun@163.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 22117b3 commit ed96824

File tree

1 file changed

+5
-2
lines changed
  • drivers/net/ethernet/atheros/atlx

1 file changed

+5
-2
lines changed

drivers/net/ethernet/atheros/atlx/atl1.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2113,8 +2113,11 @@ static int atl1_tso(struct atl1_adapter *adapter, struct sk_buff *skb,
21132113

21142114
real_len = (((unsigned char *)iph - skb->data) +
21152115
ntohs(iph->tot_len));
2116-
if (real_len < skb->len)
2117-
pskb_trim(skb, real_len);
2116+
if (real_len < skb->len) {
2117+
err = pskb_trim(skb, real_len);
2118+
if (err)
2119+
return err;
2120+
}
21182121
hdr_len = skb_tcp_all_headers(skb);
21192122
if (skb->len == hdr_len) {
21202123
iph->check = 0;

0 commit comments

Comments
 (0)