Skip to content

Commit 6620999

Browse files
lopsided98akpm00
authored andcommitted
scripts/gdb/vmalloc: disable on no-MMU
vmap_area does not exist on no-MMU, therefore the GDB scripts fail to load: Traceback (most recent call last): File "<...>/vmlinux-gdb.py", line 51, in <module> import linux.vmalloc File "<...>/scripts/gdb/linux/vmalloc.py", line 14, in <module> vmap_area_ptr_type = vmap_area_type.get_type().pointer() ^^^^^^^^^^^^^^^^^^^^^^^^^ File "<...>/scripts/gdb/linux/utils.py", line 28, in get_type self._type = gdb.lookup_type(self._name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ gdb.error: No struct type named vmap_area. To fix this, disable the command and add an informative error message if CONFIG_MMU is not defined, following the example of lx-slabinfo. Link: https://lkml.kernel.org/r/20231031202235.2655333-2-ben.wolsieffer@hefring.com Fixes: 852622b ("scripts/gdb/vmalloc: add vmallocinfo support") Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com> Cc: Jan Kiszka <jan.kiszka@siemens.com> Cc: Kieran Bingham <kbingham@kernel.org> Cc: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 1650163 commit 6620999

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

scripts/gdb/linux/constants.py.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,3 +158,4 @@ LX_CONFIG(CONFIG_STACKDEPOT)
158158
LX_CONFIG(CONFIG_PAGE_OWNER)
159159
LX_CONFIG(CONFIG_SLUB_DEBUG)
160160
LX_CONFIG(CONFIG_SLAB_FREELIST_HARDENED)
161+
LX_CONFIG(CONFIG_MMU)

scripts/gdb/linux/vmalloc.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@
1010
import re
1111
from linux import lists, utils, stackdepot, constants, mm
1212

13-
vmap_area_type = utils.CachedType('struct vmap_area')
14-
vmap_area_ptr_type = vmap_area_type.get_type().pointer()
13+
if constants.LX_CONFIG_MMU:
14+
vmap_area_type = utils.CachedType('struct vmap_area')
15+
vmap_area_ptr_type = vmap_area_type.get_type().pointer()
1516

1617
def is_vmalloc_addr(x):
1718
pg_ops = mm.page_ops().ops
@@ -25,6 +26,9 @@ def __init__(self):
2526
super(LxVmallocInfo, self).__init__("lx-vmallocinfo", gdb.COMMAND_DATA)
2627

2728
def invoke(self, arg, from_tty):
29+
if not constants.LX_CONFIG_MMU:
30+
raise gdb.GdbError("Requires MMU support")
31+
2832
vmap_area_list = gdb.parse_and_eval('vmap_area_list')
2933
for vmap_area in lists.list_for_each_entry(vmap_area_list, vmap_area_ptr_type, "list"):
3034
if not vmap_area['vm']:

0 commit comments

Comments
 (0)