Skip to content

Commit 1650163

Browse files
clementlegerakpm00
authored andcommitted
scripts/gdb: fix usage of MOD_TEXT not defined when CONFIG_MODULES=n
MOD_TEXT is only defined if CONFIG_MODULES=y which lead to loading failure of the gdb scripts when kernel is built without CONFIG_MODULES=y: Reading symbols from vmlinux... Traceback (most recent call last): File "/foo/vmlinux-gdb.py", line 25, in <module> import linux.constants File "/foo/scripts/gdb/linux/constants.py", line 14, in <module> LX_MOD_TEXT = gdb.parse_and_eval("MOD_TEXT") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ gdb.error: No symbol "MOD_TEXT" in current context. Add a conditional check on CONFIG_MODULES to fix this error. Link: https://lkml.kernel.org/r/20231031134848.119391-1-da.gomez@samsung.com Fixes: b4aff75 ("scripts/gdb: use mem instead of core_layout to get the module address") Signed-off-by: Clément Léger <cleger@rivosinc.com> Tested-by: Daniel Gomez <da.gomez@samsung.com> Signed-off-by: Daniel Gomez <da.gomez@samsung.com> Cc: Jan Kiszka <jan.kiszka@siemens.com> Cc: Kieran Bingham <kbingham@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: Pankaj Raghav <p.raghav@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 4aa8f27 commit 1650163

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

scripts/gdb/linux/constants.py.in

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,11 @@ LX_GDBPARSED(IRQD_LEVEL)
6666
LX_GDBPARSED(IRQ_HIDDEN)
6767

6868
/* linux/module.h */
69-
LX_GDBPARSED(MOD_TEXT)
70-
LX_GDBPARSED(MOD_DATA)
71-
LX_GDBPARSED(MOD_RODATA)
72-
LX_GDBPARSED(MOD_RO_AFTER_INIT)
69+
if IS_BUILTIN(CONFIG_MODULES):
70+
LX_GDBPARSED(MOD_TEXT)
71+
LX_GDBPARSED(MOD_DATA)
72+
LX_GDBPARSED(MOD_RODATA)
73+
LX_GDBPARSED(MOD_RO_AFTER_INIT)
7374

7475
/* linux/mount.h */
7576
LX_VALUE(MNT_NOSUID)

0 commit comments

Comments
 (0)