Skip to content

Commit 65ef13f

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: mmp: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-21-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 678471d commit 65ef13f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/clk/mmp/clk-audio.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -384,12 +384,10 @@ static int mmp2_audio_clk_probe(struct platform_device *pdev)
384384
return ret;
385385
}
386386

387-
static int mmp2_audio_clk_remove(struct platform_device *pdev)
387+
static void mmp2_audio_clk_remove(struct platform_device *pdev)
388388
{
389389
pm_clk_destroy(&pdev->dev);
390390
pm_runtime_disable(&pdev->dev);
391-
392-
return 0;
393391
}
394392

395393
#ifdef CONFIG_PM
@@ -436,7 +434,7 @@ static struct platform_driver mmp2_audio_clk_driver = {
436434
.pm = &mmp2_audio_clk_pm_ops,
437435
},
438436
.probe = mmp2_audio_clk_probe,
439-
.remove = mmp2_audio_clk_remove,
437+
.remove_new = mmp2_audio_clk_remove,
440438
};
441439
module_platform_driver(mmp2_audio_clk_driver);
442440

0 commit comments

Comments
 (0)