Skip to content

Commit 678471d

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: keystone: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-19-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent bfa8370 commit 678471d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/clk/keystone/sci-clk.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -689,16 +689,14 @@ static int ti_sci_clk_probe(struct platform_device *pdev)
689689
* via common clock framework. Any memory allocated for the device will
690690
* be free'd silently via the devm framework. Returns 0 always.
691691
*/
692-
static int ti_sci_clk_remove(struct platform_device *pdev)
692+
static void ti_sci_clk_remove(struct platform_device *pdev)
693693
{
694694
of_clk_del_provider(pdev->dev.of_node);
695-
696-
return 0;
697695
}
698696

699697
static struct platform_driver ti_sci_clk_driver = {
700698
.probe = ti_sci_clk_probe,
701-
.remove = ti_sci_clk_remove,
699+
.remove_new = ti_sci_clk_remove,
702700
.driver = {
703701
.name = "ti-sci-clk",
704702
.of_match_table = of_match_ptr(ti_sci_clk_of_match),

0 commit comments

Comments
 (0)