Skip to content

Commit 505a2d1

Browse files
davejiangvinodkoul
authored andcommitted
dmaengine: idxd: add RO check for wq max_transfer_size write
Block wq_max_transfer_size_store() when the device is configured as read-only and not configurable. Fixes: d7aad55 ("dmaengine: idxd: add support for configurable max wq xfer size") Reported-by: Bernice Zhang <bernice.zhang@intel.com> Tested-by: Bernice Zhang <bernice.zhang@intel.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/164971488154.2200913.10706665404118545941.stgit@djiang5-desk3.ch.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 6690346 commit 505a2d1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/dma/idxd/sysfs.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -905,6 +905,9 @@ static ssize_t wq_max_transfer_size_store(struct device *dev, struct device_attr
905905
u64 xfer_size;
906906
int rc;
907907

908+
if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
909+
return -EPERM;
910+
908911
if (wq->state != IDXD_WQ_DISABLED)
909912
return -EPERM;
910913

0 commit comments

Comments
 (0)