Skip to content

Commit 6690346

Browse files
davejiangvinodkoul
authored andcommitted
dmaengine: idxd: add RO check for wq max_batch_size write
Block wq_max_batch_size_store() when the device is configured as read-only and not configurable. Fixes: e7184b1 ("dmaengine: idxd: add support for configurable max wq batch size") Reported-by: Bernice Zhang <bernice.zhang@intel.com> Tested-by: Bernice Zhang <bernice.zhang@intel.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/164971493551.2201159.1942042593642155209.stgit@djiang5-desk3.ch.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent bc3452c commit 6690346

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/dma/idxd/sysfs.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -939,6 +939,9 @@ static ssize_t wq_max_batch_size_store(struct device *dev, struct device_attribu
939939
u64 batch_size;
940940
int rc;
941941

942+
if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
943+
return -EPERM;
944+
942945
if (wq->state != IDXD_WQ_DISABLED)
943946
return -EPERM;
944947

0 commit comments

Comments
 (0)