Skip to content

Commit 4eb9196

Browse files
efarmanawilliam
authored andcommitted
vfio/ccw: Check return code from subchannel quiesce
If a subchannel is busy when a close is performed, the subchannel needs to be quiesced and left nice and tidy, so nothing unexpected (like a solicited interrupt) shows up while in the closed state. Unfortunately, the return code from this call isn't checked, so any busy subchannel is treated as a failing one. Fix that, so that the close on a busy subchannel happens normally. Signed-off-by: Eric Farman <farman@linux.ibm.com> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20220728204914.2420989-4-farman@linux.ibm.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
1 parent 96a4c9e commit 4eb9196

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/s390/cio/vfio_ccw_fsm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ static void fsm_close(struct vfio_ccw_private *private,
407407

408408
ret = cio_disable_subchannel(sch);
409409
if (ret == -EBUSY)
410-
vfio_ccw_sch_quiesce(sch);
410+
ret = vfio_ccw_sch_quiesce(sch);
411411
if (ret)
412412
goto err_unlock;
413413

0 commit comments

Comments
 (0)