Skip to content

Commit 96a4c9e

Browse files
efarmanawilliam
authored andcommitted
vfio/ccw: Remove FSM Close from remove handlers
Now that neither vfio_ccw_sch_probe() nor vfio_ccw_mdev_probe() affect the FSM state, it doesn't make sense for their _remove() counterparts try to revert things in this way. Since the FSM open and close are handled alongside MDEV open/close, these are unnecessary. Signed-off-by: Eric Farman <farman@linux.ibm.com> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20220728204914.2420989-3-farman@linux.ibm.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
1 parent 5a4fe7c commit 96a4c9e

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

drivers/s390/cio/vfio_ccw_drv.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ static void vfio_ccw_sch_remove(struct subchannel *sch)
241241
{
242242
struct vfio_ccw_private *private = dev_get_drvdata(&sch->dev);
243243

244-
vfio_ccw_fsm_event(private, VFIO_CCW_EVENT_CLOSE);
245244
mdev_unregister_device(&sch->dev);
246245

247246
dev_set_drvdata(&sch->dev, NULL);

drivers/s390/cio/vfio_ccw_ops.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ static void vfio_ccw_mdev_remove(struct mdev_device *mdev)
130130

131131
vfio_unregister_group_dev(&private->vdev);
132132

133-
vfio_ccw_fsm_event(private, VFIO_CCW_EVENT_CLOSE);
134-
135133
vfio_uninit_group_dev(&private->vdev);
136134
atomic_inc(&private->avail);
137135
}

0 commit comments

Comments
 (0)