Skip to content

Commit 3c97849

Browse files
Ranjan Kumarmartinkpetersen
authored andcommitted
scsi: mpt3sas: Fix loop logic
The retry loop continues to iterate until the count reaches 30, even after receiving the correct value. Exit loop when a non-zero value is read. Fixes: 4ca10f3 ("scsi: mpt3sas: Perform additional retries if doorbell read returns 0") Cc: stable@vger.kernel.org Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com> Link: https://lore.kernel.org/r/20231020105849.6350-1-ranjan.kumar@broadcom.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 44a3165 commit 3c97849

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/scsi/mpt3sas/mpt3sas_base.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ _base_readl_ext_retry(const void __iomem *addr)
223223

224224
for (i = 0 ; i < 30 ; i++) {
225225
ret_val = readl(addr);
226-
if (ret_val == 0)
227-
continue;
226+
if (ret_val != 0)
227+
break;
228228
}
229229

230230
return ret_val;

0 commit comments

Comments
 (0)