Skip to content

Commit 44a3165

Browse files
Su Huimartinkpetersen
authored andcommitted
scsi: snic: Remove useless code in snic_dr_clean_pending_req()
Return error code directly to save space and be more clear. Signed-off-by: Su Hui <suhui@nfschina.com> Link: https://lore.kernel.org/r/20231020023326.43898-1-suhui@nfschina.com Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 82f52b2 commit 44a3165

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

drivers/scsi/snic/snic_scsi.c

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1850,7 +1850,7 @@ snic_dr_clean_pending_req(struct snic *snic, struct scsi_cmnd *lr_sc)
18501850
{
18511851
struct scsi_device *lr_sdev = lr_sc->device;
18521852
u32 tag = 0;
1853-
int ret = FAILED;
1853+
int ret;
18541854

18551855
for (tag = 0; tag < snic->max_tag_id; tag++) {
18561856
if (tag == snic_cmd_tag(lr_sc))
@@ -1859,32 +1859,26 @@ snic_dr_clean_pending_req(struct snic *snic, struct scsi_cmnd *lr_sc)
18591859
ret = snic_dr_clean_single_req(snic, tag, lr_sdev);
18601860
if (ret) {
18611861
SNIC_HOST_ERR(snic->shost, "clean_err:tag = %d\n", tag);
1862-
18631862
goto clean_err;
18641863
}
18651864
}
18661865

18671866
schedule_timeout(msecs_to_jiffies(100));
18681867

18691868
/* Walk through all the cmds and check abts status. */
1870-
if (snic_is_abts_pending(snic, lr_sc)) {
1871-
ret = FAILED;
1872-
1869+
if (snic_is_abts_pending(snic, lr_sc))
18731870
goto clean_err;
1874-
}
18751871

1876-
ret = 0;
18771872
SNIC_SCSI_DBG(snic->shost, "clean_pending_req: Success.\n");
18781873

1879-
return ret;
1874+
return 0;
18801875

18811876
clean_err:
1882-
ret = FAILED;
18831877
SNIC_HOST_ERR(snic->shost,
18841878
"Failed to Clean Pending IOs on %s device.\n",
18851879
dev_name(&lr_sdev->sdev_gendev));
18861880

1887-
return ret;
1881+
return FAILED;
18881882

18891883
} /* end of snic_dr_clean_pending_req */
18901884

0 commit comments

Comments
 (0)