Skip to content

Commit 27ff768

Browse files
committed
tracing: Test the 'Do not trace this pid' case in create event
When creating a new event (via a module, kprobe, eprobe, etc), the descriptors that are created must add flags for pid filtering if an instance has pid filtering enabled, as the flags are used at the time the event is executed to know if pid filtering should be done or not. The "Only trace this pid" case was added, but a cut and paste error made that case checked twice, instead of checking the "Trace all but this pid" case. Link: https://lore.kernel.org/all/202111280401.qC0z99JB-lkp@intel.com/ Fixes: 6cb2065 ("tracing: Check pid filtering when creating events") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent a55f224 commit 27ff768

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/trace/trace_events.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2693,7 +2693,7 @@ trace_create_new_event(struct trace_event_call *call,
26932693
lockdep_is_held(&event_mutex));
26942694

26952695
if (!trace_pid_list_first(pid_list, &first) ||
2696-
!trace_pid_list_first(pid_list, &first))
2696+
!trace_pid_list_first(no_pid_list, &first))
26972697
file->flags |= EVENT_FILE_FL_PID_FILTER;
26982698

26992699
file->event_call = call;

0 commit comments

Comments
 (0)