Skip to content

Commit a55f224

Browse files
committed
tracing: Fix pid filtering when triggers are attached
If a event is filtered by pid and a trigger that requires processing of the event to happen is a attached to the event, the discard portion does not take the pid filtering into account, and the event will then be recorded when it should not have been. Cc: stable@vger.kernel.org Fixes: 3fdaf80 ("tracing: Implement event pid filtering") Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent 6cb2065 commit a55f224

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

kernel/trace/trace.h

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1366,14 +1366,26 @@ __event_trigger_test_discard(struct trace_event_file *file,
13661366
if (eflags & EVENT_FILE_FL_TRIGGER_COND)
13671367
*tt = event_triggers_call(file, buffer, entry, event);
13681368

1369-
if (test_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &file->flags) ||
1370-
(unlikely(file->flags & EVENT_FILE_FL_FILTERED) &&
1371-
!filter_match_preds(file->filter, entry))) {
1372-
__trace_event_discard_commit(buffer, event);
1373-
return true;
1374-
}
1369+
if (likely(!(file->flags & (EVENT_FILE_FL_SOFT_DISABLED |
1370+
EVENT_FILE_FL_FILTERED |
1371+
EVENT_FILE_FL_PID_FILTER))))
1372+
return false;
1373+
1374+
if (file->flags & EVENT_FILE_FL_SOFT_DISABLED)
1375+
goto discard;
1376+
1377+
if (file->flags & EVENT_FILE_FL_FILTERED &&
1378+
!filter_match_preds(file->filter, entry))
1379+
goto discard;
1380+
1381+
if ((file->flags & EVENT_FILE_FL_PID_FILTER) &&
1382+
trace_event_ignore_this_pid(file))
1383+
goto discard;
13751384

13761385
return false;
1386+
discard:
1387+
__trace_event_discard_commit(buffer, event);
1388+
return true;
13771389
}
13781390

13791391
/**

0 commit comments

Comments
 (0)